[SYCLomatic][NFC] Skip nvshmem cases when headers are not available#2856
Merged
Conversation
tomflinda
approved these changes
May 27, 2025
tomflinda
changed the title
tomflinda
reviewed
May 27, 2025
tomflinda
reviewed
May 27, 2025
tomflinda
reviewed
May 27, 2025
tomflinda
reviewed
May 28, 2025
ShengchenJ
approved these changes
May 28, 2025
ShengchenJ
left a comment
ShengchenJ
left a comment
Contributor
There was a problem hiding this comment.
The PR is LGTM. Due to the CI system configs the NVSHMEM header files. Could you locally verify the NVSHMEM cases are skipped?
Contributor
Author
|
Yes, the tests are skipped
|
zhimingwang36
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to skip nvSHMEM lit test cases when the nvshmem.h header is unavailable in the machine.